Bump stylelint and stylelint-config-recommended #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/stylelint-and-stylelint-config-recommended-16.0.2
branch
2 times, most recently
from
28d3dce to
e7df5ae
Compare
jo-sm
added a commit
that referenced
this pull request
Dec 12, 2023
As part of looking into #887 I ran into a ton of difficulty getting `ts-jest` to work with ESM, with one of the main issues being related to importing `./utils.js` style files. This seems to be an issue with `ts-jest` (or at least the interplay between `ts-jest` and Jest) and from what I could tell in the issues and code, this isn't solved yet. The solution to the underlying issue was "fixed" by suggesting the use of a custom resolver, which is not part of the main `ts-jest` package (see kulshekhar/ts-jest#1057). While checking types in the test code is useful, it's not that important since the actual code is type checked separately (both with the linter and the compilation steps), and so instead of trying to fix `ts-jest` and use the custom resolver, I opt for using `@swc/jest` which instead removes the types entirely.
jo-sm
added a commit
that referenced
this pull request
Dec 12, 2023
As part of looking into #887 I ran into a ton of difficulty getting `ts-jest` to work with ESM, with one of the main issues being related to importing `./utils.js` style files. This seems to be an issue with TypeScript + Jest combination when using ESM, and the `ts-jest` preset hasn't "fixed" this yet (by doing something like the `moduleNameMapper` approach mentioned in [comments like this] (kulshekhar/ts-jest#1057 (comment)). Has there not been any PR from someone? In any case, it's a bit frustrating that there wasn't a mention of this in the troubleshooting docs as the issue above was pretty well trafficked and commented on, and while there was a PR, it was closed and there was no follow up. What's worse is that this issue has been known for at least 4 years. There really should have been a troubleshooting section added here even without a community contributed PR, and so I don't have faith that either an additon to the preset or a mention in the troubleshooting docs will happen anytime soon, at least before I want to get Stylelint 16 in main. While checking types in the test code is useful, it's not that important since the actual code is type checked separately (both with the linter and the compilation steps), and so instead of trying to fix `ts-jest` and use the custom resolver, I opt for using `@swc/jest` which instead removes the types entirely when compiling TS to JS. It has the added benefit of being simpler, being only used in the `transform` config rather than as a preset. If at some point type checking the tests becomes important the lint:types task can be updated to check test code too.
jo-sm
added a commit
that referenced
this pull request
Dec 12, 2023
As part of looking into #887 I ran into a ton of difficulty getting `ts-jest` to work with ESM, with one of the main issues being related to importing `./utils.js` style files. This seems to be an issue with the combination of TypeScript + Jest when using ESM, and the `ts-jest` preset hasn't "fixed" this yet (by doing something like the `moduleNameMapper` approach mentioned in [comments like this] (kulshekhar/ts-jest#1057 (comment)). Has there not been any PR from someone? In any case, it's a bit frustrating that there wasn't a mention of this in the troubleshooting docs as the issue above was pretty well trafficked and commented on, and while there was a PR, it was closed and there was no follow up. What's worse is that this issue has been known for at least 4 years. There really should have been a troubleshooting section added here even without a community contributed PR, and so I don't have faith that either an additon to the preset or a mention in the troubleshooting docs will happen anytime soon, at least before I want to get Stylelint 16 in main. While checking types in the test code is useful, it's not that important since the actual code is type checked separately (both with the linter and the compilation steps), and so instead of trying to fix `ts-jest` and use the custom resolver, I opt for using `@swc/jest` which instead removes the types entirely when compiling TS to JS. It has the added benefit of being simpler, being only used in the `transform` config rather than as a preset. If at some point type checking the tests becomes important the lint:types task can be updated to check test code too.
jo-sm
added a commit
that referenced
this pull request
Dec 12, 2023
As part of looking into #887 I ran into a ton of difficulty getting `ts-jest` to work with ESM, with one of the main issues being related to importing `./utils.js` style files. This seems to be an issue with the combination of TypeScript + Jest when using ESM, and the `ts-jest` preset hasn't "fixed" this yet (by doing something like the `moduleNameMapper` approach mentioned in [comments like this](kulshekhar/ts-jest#1057 (comment)). Has there not been any PR from someone? In any case, it's a bit frustrating that there wasn't a mention of this in the troubleshooting docs as the issue above was pretty well trafficked and commented on, and while there was a PR, it was closed and there was no follow up. What's worse is that this issue has been known for at least 4 years. There really should have been a troubleshooting section added here even without a community contributed PR, and so I don't have faith that either an additon to the preset or a mention in the troubleshooting docs will happen anytime soon, at least before I want to get Stylelint 16 in main. While checking types in the test code is useful, it's not that important since the actual code is type checked separately (both with the linter and the compilation steps), and so instead of trying to fix `ts-jest` and use the custom resolver, I opt for using `@swc/jest` which instead removes the types entirely when compiling TS to JS. It has the added benefit of being simpler, being only used in the `transform` config rather than as a preset. If at some point type checking the tests becomes important the lint:types task can be updated to check test code too.
jo-sm
added a commit
that referenced
this pull request
Dec 12, 2023
As part of looking into #887 I ran into a ton of difficulty getting `ts-jest` to work with ESM, with one of the main issues being related to importing `./utils.js` style files. This seems to be an issue with the combination of TypeScript + Jest when using ESM, and the `ts-jest` preset hasn't "fixed" this yet (by doing something like the `moduleNameMapper` approach mentioned in [comments like this](kulshekhar/ts-jest#1057 (comment)). Has there not been any PR from someone? In any case, it's a bit frustrating that there wasn't a mention of this in the troubleshooting docs as the issue above was pretty well trafficked and commented on, and while there was a PR, it was closed and there was no follow up. What's worse is that this issue has been known for at least 4 years. There really should have been a troubleshooting section added here even without a community contributed PR, and so I don't have faith that either an additon to the preset or a mention in the troubleshooting docs will happen anytime soon, at least before I want to get Stylelint 16 in main. While checking types in the test code is useful, it's not that important since the actual code is type checked separately (both with the linter and the compilation steps), and since `@swc/jest` is simpler and hopefully doesn't have the above frustration factor, I've decided to migrate from `ts-jest` to `@swc/jest`. If at some point type checking the tests becomes important the lint:types task can be updated to check test code too.
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/stylelint-and-stylelint-config-recommended-16.0.2
branch
8 times, most recently
from
ce3844b to
438fc49
Compare
Bumps [stylelint](https://github.com/stylelint/stylelint) and [stylelint-config-recommended](https://github.com/stylelint/stylelint-config-recommended). These dependencies needed to be updated together. Updates `stylelint` from 15.11.0 to 16.0.2 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@15.11.0...16.0.2) Updates `stylelint-config-recommended` from 13.0.0 to 14.0.0 - [Release notes](https://github.com/stylelint/stylelint-config-recommended/releases) - [Changelog](https://github.com/stylelint/stylelint-config-recommended/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-recommended@13.0.0...14.0.0) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:production update-type: version-update:semver-major - dependency-name: stylelint-config-recommended dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/stylelint-and-stylelint-config-recommended-16.0.2
branch
from
438fc49 to
c9b2368
Compare
|
Superseded by #900. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/stylelint-and-stylelint-config-recommended-16.0.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps stylelint and stylelint-config-recommended. These dependencies needed to be updated together.
Updates
stylelintfrom 15.11.0 to 16.0.2Release notes
Sourced from stylelint's releases.
... (truncated)
Changelog
Sourced from stylelint's changelog.
Commits
da7ce2116.0.2303b3c9Prepare 16.0.2 (#7386)fbc6adfBump rollup from 4.6.1 to 4.8.0 (#7394)d4b12aaBump np from 8.0.4 to 9.2.0 (#7391)0ec3df4Bump the typescript group with 1 update (#7390)203276eBump the jest group with 1 update (#7389)dde101dFixERR_UNSUPPORTED_ESM_URL_SCHEMEerror on Windows (#7383)2a82f4dDocument node:test testRule (#7381)bc9225e16.0.1d5f9d19Prepare 16.0.1 (#7379)Updates
stylelint-config-recommendedfrom 13.0.0 to 14.0.0Release notes
Sourced from stylelint-config-recommended's releases.
Changelog
Sourced from stylelint-config-recommended's changelog.
Commits
8e6a0f714.0.0f829725Prepare 14.0.0 (#204)d0c62e5Bump@babel/traversefrom 7.22.5 to 7.23.2 (#202)8cafd6eBump postcss from 8.4.24 to 8.4.31 (#201)fef405aBump word-wrap from 1.2.3 to 1.2.4 (#200)6a7633dBump stylelint from 15.10.0 to 15.10.1 (#198)6e5406eFixengines.test.jsfor multiple potential versions (#197)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)