Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalafix 0.10.0 #91

Merged
merged 1 commit into from
Apr 8, 2022
Merged

scalafix 0.10.0 #91

merged 1 commit into from
Apr 8, 2022

Conversation

bjaglin
Copy link
Contributor

@bjaglin bjaglin commented Apr 3, 2022

@bjaglin
Copy link
Contributor Author

bjaglin commented Apr 3, 2022

@joan38 any chance you can approve the worflow to run so I get feedback? Thanks in advance!

@joan38
Copy link
Owner

joan38 commented Apr 3, 2022

Done

@bjaglin
Copy link
Contributor Author

bjaglin commented Apr 3, 2022

Thanks, it looks good. Once the final release is cut, it would be nice to get a major release of your client ASAP.

That's because of the breaking change explained in https://github.com/scalacenter/scalafix/releases/tag/v0.10.0-RC1: if rules start building against scalafix 0.10.x, they will unfortunately fail at runtime with existing clients using scalafix 0.9.x (scalacenter/scalafix#1562 tried to improve the error message, but it's not trivial). OrganizeImports being the most widely used one, let's wait until a 0.10.x-built mill-scalafix release is published to publish a 0.10.x-built OrganizeImports, as suggested in liancheng/scalafix-organize-imports#264.

@joan38
Copy link
Owner

joan38 commented Apr 3, 2022

Thanks @bjaglin for taking care of this!

@bjaglin bjaglin changed the title try scalafix 0.10.0-RC1 scalafix 0.10.0 Apr 7, 2022
@bjaglin
Copy link
Contributor Author

bjaglin commented Apr 7, 2022

@joan38 0.10.0 is out

@bjaglin bjaglin marked this pull request as ready for review April 7, 2022 19:31
@joan38 joan38 merged commit bf27bc7 into joan38:master Apr 8, 2022
@rvacaru
Copy link

rvacaru commented Jul 8, 2022

Hi @joan38, I'm Razvan, GSoC contributor for scalafix and @bjaglin is my GSoC mentor.

TLDR: We'd like a release of mill-scalafix which includes this PR.

As part of the project I'm cross compiling scalafix in scala 3, however in scalafix-core there's a macro for better error message / readability.
We want to remove this hack for the next scalafix-core/scalafix release, and by having a release of mill-scalafix depending on scalafix 0.10.x we'd still have good error readability on such release.

Would this be possible?

@joan38
Copy link
Owner

joan38 commented Jul 8, 2022

Hi @rvacaru !
Oh I did not realize that was not released yet.
I will merge the open PRs and make a release now.

@joan38
Copy link
Owner

joan38 commented Jul 8, 2022

Also note that we have snapshot releases on every commit, the latest being 0.2.8-6-dd9c632-SNAPSHOT

@joan38
Copy link
Owner

joan38 commented Jul 8, 2022

0.2.9 is out

@rvacaru
Copy link

rvacaru commented Jul 8, 2022

Thanks a lot for the quick response @joan38! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants