Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown LSP via Marksman #1013

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

artempyanykh
Copy link
Contributor

Marksman is an LSP server for Markdown: https://github.com/artempyanykh/marksman

It supports a bunch of LSP features such as symbols, references, rename, diagnostics, etc. and already has integrations with a number of LSP clients.

Context: I'm the author of Marksman and recently started using it with Eglot. I figured it would be nice to have an out-of-the-box support.

@manuel-uberti
Copy link
Contributor

manuel-uberti commented Aug 22, 2022

It probably makes sense to update the Connecting to a server section of the README and NEWS.md as well since you're at it. :)

Edit: see https://github.com/joaotavora/eglot/pull/961/files for example.

@joaotavora
Copy link
Owner

joaotavora commented Aug 22, 2022

Yes, please find similar pull requests and do all of those actions. Then do a commit entry like this

Add Foo server

* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add foo-server.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes

@artempyanykh
Copy link
Contributor Author

@manuel-uberti @joaotavora sounds good, thanks! I'll update the PR shortly.

* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add marksman.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
@artempyanykh
Copy link
Contributor Author

Pushed an update. LMK if this looks good now.

@joaotavora joaotavora merged commit c32e9bf into joaotavora:master Sep 8, 2022
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 18, 2022
* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add marksman.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add marksman.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add marksman.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
#1013: joaotavora/eglot#1013
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Oct 12, 2022
* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add marksman.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
GitHub-reference: close joaotavora/eglot#1013
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Oct 20, 2022
* eglot.el (eglot-server-programs): Update.
* README (Connecting to a server): Add marksman.
* NEWS.md: Mention change.

Copyright-paperwork-exempt: yes
GitHub-reference: close joaotavora/eglot#1013
Freed-Wu referenced this pull request in artempyanykh/marksman Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants