Ignore property types #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now ignore properties that have specific types instead of the whole type.
E.g.
schema
```
type Role {
name: String!
}
type User {
email: String!,
roles: [Role]!
}
```
gql2flow --ignore-property-types "Role"
```
type User = {
email: string
}
type Role = {
name: string
}
```
gql2flow
```
type User = {
email: string,
roles: Array<Role>
}
type Role = {
name: string
}
```
The reason is that I needed these types to annotate my resolver functions in apollo.
joarwilk
requested changes
Sep 4, 2017
| @@ -143,7 +143,7 @@ ${fields} | |||
| let f = isInput ? type.inputFields : type.fields || []; | |||
|
|
|||
| let fields = f | |||
| .filter(field => filterField(field, ignoredTypes)) | |||
| .filter(field => filterField(field, ignoredPropertyTypes)) | |||
There was a problem hiding this comment.
Is this correct? Shouldn't it filter for both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes you can now ignore properties that have specific types instead of the whole type.
I'm not that familiar with the spec, so I might have missed some use cases. This just works well enough for me since I'm just using regular ol' types.
E.g.
schema
gql2flow --ignore-property-types "Role"
gql2flow
The reason is that I needed these types to annotate my resolver functions in apollo.