-
Notifications
You must be signed in to change notification settings - Fork 128
Complete placeholder font & icon active color #119
Conversation
Add placeholderFont property
…1-PlaceholderFont Add placeholderFont handling
Placeholder fixes
Draw password toggleable icon with active color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove setter before merging.
Nice PR, thank you.
@@ -70,6 +70,11 @@ extension AnimatedTextView: TextInput { | |||
set { self.autocorrectionType = newValue } | |||
} | |||
|
|||
public var rightView: UIView? { | |||
get { return nil } | |||
set { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove setter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UITextField public interface requires setter.
Yes, this code is unused in text view, but it's needed for AnimatedTextField
@@ -78,6 +78,7 @@ struct CustomTextInputStyle: AnimatedTextInputStyle { | |||
let lineHeight: CGFloat = 3 | |||
let errorColor = UIColor.red | |||
let textInputFont = UIFont.systemFont(ofSize: 14) | |||
let placeHolderFont = UIFont.systemFont(ofSize: 14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious.. Have you tried that the component is working when placeHolderFont.pointSize > textInputFont.pointSize ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will work, but basically you want input font & placeholder font to be the same.
... Now I start thinking if we ever need to set placeholderFont to anything other than textInputFont.
…Input into jobandtalent-master # Conflicts: # AnimatedTextInput/Classes/AnimatedTextInput.swift # AnimatedTextInput/Classes/AnimatedTextView.swift
@victorBaro Nothing else to change, please acccept |
Completes #91, #103, #110
Updated readme style, style in example project.
Checked on iOS 12 XS.
Ran tests (did not find snapshot references)