Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new particle spray model by Chen+24 #670

Merged
merged 21 commits into from
Sep 13, 2024

Conversation

ybillchen
Copy link
Contributor

Implement the new particle spray model by Chen+24 and include progenitor's potential for stream integration

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (7c5ad82) to head (8621961).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         200      200           
  Lines       29269    29322   +53     
  Branches      564      564           
=======================================
+ Hits        29243    29296   +53     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobovy
Copy link
Owner

jobovy commented Aug 15, 2024

Thanks for starting the PR. You might want to install and use precommit as discussed in the development installation docs that I linked to in my email. That would avoid all the tweaks by precommit.

@ybillchen
Copy link
Contributor Author

Thanks for starting the PR. You might want to install and use precommit as discussed in the development installation docs that I linked to in my email. That would avoid all the tweaks by precommit.

Thank you! This is very useful.

@ybillchen
Copy link
Contributor Author

Hi @jobovy,

This PR have passed most checks! I also added some new tests, documentation, and updated HISTORY.txt.

Let me know if more is needed!

-Bill

@jobovy
Copy link
Owner

jobovy commented Aug 16, 2024

Hi @jobovy,

This PR have passed most checks! I also added some new tests, documentation, and updated HISTORY.txt.

Let me know if more is needed!

-Bill

Thanks! I’ll review this next week.

Copy link
Owner

@jobovy jobovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ybillchen --I did a first review mainly focusing on the code in streamspraydf and the tests, but not yet the documentation. Overall it looks great and great job on the tests! I have a bunch of comments that should be addressed before this can be merged. I might have more comments later, these are just some major ones to get started. Thanks!

galpy/df/__init__.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
Copy link
Owner

@jobovy jobovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small comments on the latest changes.

galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
galpy/df/streamspraydf.py Outdated Show resolved Hide resolved
@jobovy
Copy link
Owner

jobovy commented Aug 28, 2024

Sorry for the delay in finishing this review, I'm hoping to get to this later this week.

@jobovy jobovy merged commit 6c9bb85 into jobovy:main Sep 13, 2024
90 checks passed
@jobovy
Copy link
Owner

jobovy commented Sep 15, 2024

Sorry for the delay, but I was finally able to do a final review of the documentation updates and after a few small tweaks was able to merge this. Thanks again for your contribution @ybillchen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants