Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize test function using pytest.mark.parametrize #1

Conversation

danceratopz
Copy link

Parametrizes the test function instead of looping over the test vectors within it.

This generates many more test cases and therefore more verbose pytest output. You may want to restrict the number of test cases when debugging locally, for example by specifying a single fork:

fill tests/byzantium/precompiles/test_05_modexp.py --fork Byzantium

Stopping execution upon the first failing test via -x is also useful.

@jochem-brouwer
Copy link
Owner

Thanks for this PR! I will follow up ASAP 😄

@jochem-brouwer jochem-brouwer merged commit 5033153 into jochem-brouwer:precompile-modexp-test-cases Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants