Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checker to extract expiring certificates from cert requests #143

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

simonwilli
Copy link
Contributor

Added a new checker to extract metrics from expiring certificates which are stored in certificate requests.

Copy link
Owner

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i apologize for sitting on this so long. i've been very busy with my normal job. if you can take care of some small cleanup, i'll merge.

helm/cert-exporter/Chart.yaml Outdated Show resolved Hide resolved
src/metrics/metrics.go Show resolved Hide resolved
@simonwilli
Copy link
Contributor Author

i apologize for sitting on this so long. i've been very busy with my normal job. if you can take care of some small cleanup, i'll merge.

No worries, thank you for your review :) I've added your small remarks

Copy link
Owner

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice feature!

After this PR is merged: #151

I'll do a build

@joe-elliott joe-elliott merged commit 489e98c into joe-elliott:master Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants