Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Crow Facts for #298 #316

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added Crow Facts for #298 #316

wants to merge 7 commits into from

Conversation

yedhink
Copy link

@yedhink yedhink commented Oct 2, 2018

entry for #298

@mpentler
Copy link
Collaborator

Hello @yedhink ! Can you do two things? Can you take the latest codebase and submit this again? Also, can you check some facts to see that they work independently of seeing the other crow facts?

Pending that this all looks good. Crows are amazing!

@mpentler
Copy link
Collaborator

mpentler commented Dec 8, 2018

@yedhink are you still here? I want to take these facts because they are very good, but significant work has been done since you submitted this PR. Are you able to rebase and complete the required changes?

@yedhink
Copy link
Author

yedhink commented Dec 10, 2018

Sorry for being very late. Little bit of exams and stuff. Hope you can understand :). By the way i hope I have fixed what you have asked for.

@mpentler
Copy link
Collaborator

Oh man, this is so close to being ready, but there are some conflict markers left in. One final edit? :)

@yedhink
Copy link
Author

yedhink commented Dec 11, 2018

yes. tell me what's to be corrected?

@yedhink
Copy link
Author

yedhink commented Dec 21, 2018

ahh any problems with merging this?

Removed conflict markers
@mpentler
Copy link
Collaborator

mpentler commented Jan 2, 2019

Yeah, I'm sorry buddy, still a few things. One issue I've just noticed is that the facts need to work independently of each other. So each fact must have the word "crow" in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants