[5.x] fix: duplicate route names #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personal Note: requires tests to ensure caching isn't broken |
|
any progress on this? |
|
I just ran into this error. Glad the solution already exists. Will wait for the next release. Thanks for the package! |
|
@Supernova3339 nope. I've had a pretty bad flu/cold for the last week or so and still recovering. Will carve out some time for it this week, but I have no set date for release. When it's out, you will be the first to know 👍 |
|
Awesome! Thanks, Joel!
…On Fri, Nov 17, 2023, 3:28 PM Joel Butcher ***@***.***> wrote:
Merged #313 <#313> into
5.x.
—
Reply to this email directly, view it on GitHub
<#313 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APESZJWBIT5BOHMBSUS6ZX3YE7JG5AVCNFSM6AAAAAA7AIUBIOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHE4TSMRYGMZTIOA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
Route::match(…)to resolve the OAuth callback for both GET and POST HTTP verbs in order to cache the route for both methods with the same name.Addresses issues identified in #288