Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for Java 17 #1573

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

wlsc
Copy link

@wlsc wlsc commented Nov 6, 2023

Hey @joelittlejohn !

I am not sure you need this, but here is Java 17 support for the wonderful library that I am using constantly in my daily work.
Please feel free to point on things that I've missed out -- I did spent on this only half an hour or so and just run the build on Java 17

@unkish
Copy link
Collaborator

unkish commented Sep 13, 2024

Without changes to workflows GH actions will fail

@wlsc
Copy link
Author

wlsc commented Sep 13, 2024

Without changes to workflows GH actions will fail

this project seems to be dead, anyway

@unkish
Copy link
Collaborator

unkish commented Sep 29, 2024

this project seems to be dead, anyway

I am sorry to hear that you're feeling this way.
I am positive that repository owner put a lot of effort and time into given project.
There might be various reasons for why certain things take time or are not given a go.

That being said - You are entitled to your opinion.

@wlsc
Copy link
Author

wlsc commented Sep 29, 2024

this project seems to be dead, anyway

I am sorry to hear that you're feeling this way. I am positive that repository owner put a lot of effort and time into given project. There might be various reasons for why certain things take time or are not given a go.

That being said - You are entitled to your opinion.

Thank you for your response. I understand that there may be various reasons for delays or decisions not being made. However, a brief update indicating that it's not a current priority would have been appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants