Specify target JVM version #454
Conversation
|
@joelittlejohn this change adds a new configuration option. The naming is strange for the Ant task and I am not very proficient at Gradle, so any notes around those items would be appreciated. |
ctrimble
force-pushed
the
feature_target-version
branch
4 times, most recently
from
069ee4e
to
9d0d1d4
Compare
|
@joelittlejohn I think the PR that adds the target option is ready to merge. |
|
Looks like I forgot setTarget( String target ) in the ant task and associated documentation. |
ctrimble
force-pushed
the
feature_target-version
branch
2 times, most recently
from
b5c029c
to
9f6fbee
Compare
| @@ -65,7 +65,7 @@ public void antTaskDocumentationIncludesAllProperties() throws IntrospectionExce | |||
| String documentation = FileUtils.readFileToString(new File("../jsonschema2pojo-ant/src/site/Jsonschema2PojoTask.html")); | |||
|
|
|||
| for (Field f : Jsonschema2PojoTask.class.getDeclaredFields()) { | |||
| assertThat(documentation, containsString(f.getName())); | |||
| assertThat(documentation, containsString(">"+f.getName()+"<")); | |||
|
Looking good to me. One thing, I think target here is a little confusing as it's easy to confuse this with the target directory. I prefer targetVersion everywhere, as you've used in the CLI. |
|
Other than that change, I can't see anything else to comment on. Nice work, I'll merge when you're ready. |
ctrimble
force-pushed
the
feature_target-version
branch
from
3c5af3d
to
08e3d12
Compare
| @@ -131,6 +131,9 @@ | |||
|
|
|||
| @Parameter(names = { "-da", "--disable-accessors" }, description = "Whether to omit getter/setter methods and create public fields instead.") | |||
| private boolean disableAccessors = false; | |||
|
|
|||
| @Parameter(names = { "-tv", "--target-version" }, description = "Target version for generated source files.") | |||
There was a problem hiding this comment.
This is the best way to describe this setting. Make all descriptions like this one.
ctrimble
force-pushed
the
feature_target-version
branch
from
08e3d12
to
233418e
Compare
|
@joelittlejohn |
Specify target JVM version
Exposes a
targetVersionproperty to the rules and test compiler, specifying the target Java version to generate for.This fixes an issue during cross compilation where the source generated is valid for the JVM running the test suite but not for the JVM being targeted. For instance, auto boxing a cast like
(int)valueworks inJava7but not inJava6.Interface Changes:
targetVersionconfig property, with a default value ofmaven.compiler.target.targetVersionproperty, with a default value of1.6targetVersionproperty, with a default value of1.6-tvand--target-version, with a default value of1.6Limitations: This patch does not set the bootclasspath from
toolchains.xml. So, there can still be issues whereJava7classes and methods are referenced when generating code forJava6. I attempted to add support using classes from Maven, but there is a classpath conflict with the testing forAnt.-Xlint:-optionshas been set during testing, to suppress warnings related to this.The changes here were taken from #386.