Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate hashCode and equals even without declared fields #611

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Generate hashCode and equals even without declared fields #611

merged 1 commit into from
Aug 22, 2016

Conversation

thachhoang
Copy link
Collaborator

In these generated methods, call the super version only if
the type does not extend java.lang.Object.

Fix #610.

@thachhoang
Copy link
Collaborator Author

@joelittlejohn Thanks for adding me to the repo.

@joelittlejohn
Copy link
Owner

No problem. Thanks for submitting this PR. I'll take a proper look tomorrow but from a brief glance it looks great 👍

@joelittlejohn
Copy link
Owner

@thachhoang only comment here: could you move the integration tests into IncludeHashCodeAndEqualsIT?

@thachhoang
Copy link
Collaborator Author

I'll move the tests. Should I move the test json files elsewhere?

@joelittlejohn
Copy link
Owner

No, location you have used for those is good. Thanks.

On 21 Aug 2016 9:29 p.m., "Thach Hoang" notifications@github.com wrote:

I'll move the tests. Should I move the test json files elsewhere?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#611 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAp5MJtEGbv0ez1yjhrLZQgdYlgporSbks5qiLUzgaJpZM4JpKxZ
.

@thachhoang
Generate hashCode and equals even without declared fields
b0ce600 
In these generated methods, call the super version only if
the type does not extend java.lang.Object.

Fix joelittlejohn#610.
@joelittlejohn joelittlejohn merged commit 0c2de26 into joelittlejohn:master Aug 22, 2016
@joelittlejohn joelittlejohn added this to the 0.4.25 milestone Aug 22, 2016
@thachhoang thachhoang deleted the bugfix/equals-super branch August 22, 2016 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.25
Development

Successfully merging this pull request may close these issues.
2 participants
@thachhoang @joelittlejohn