org.jsonschema2pojo.ContentResolverTest require internet connection (… #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrimble
reviewed
Mar 17, 2017
| * @author {@link "https://github.com/s13o" "s13o"} | ||
| * @since 3/16/2017 | ||
| */ | ||
| public class LocalHttpServerBuilder { |
There was a problem hiding this comment.
I know it doesn't seem like one endpoint is worth bringing in a library, but the project will have to lug this implementation around. We should use some kind of library for this. This entire PR should be somewhere in the 20 line range.
There was a problem hiding this comment.
Yes I agree, particularly as this would be a test dependency only. Let's use wiremock 👍
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to resolve the issue #704 without adding of external dependencies