Update MyFantasyLeague for playoff weeks #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ryandaydev could you run a |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Corrects the situation where a MyFantasyLeague weekly schedule has a single matchup (championship week) by converting the matchup element to a list[] like the other weeks.
Corrects the situation where matchups is missing (skipped week) by breaking the week loop. (This might be better if it just skipped the rest of the code and continued to the next week to account for skipped weeks other than the final week.)
Testing
All tests pass 100%
(Didn't create any new tests, sorry.)
Background:
@joeyagreco When I was testing Leeger with MyFantasyLeague I found that it received errors in week 17 (championship) and 18 (skipped) of my league data. That's because the schedule object is a bit different than the rest of the weeks:
Weeks 1-16 - matchup is a list[] of matchups
"schedule": { "weeklySchedule": { "week": "16", "matchup": [ { "franchise": [ {...Week 17 - matchup is a single matchup element
"schedule": { "weeklySchedule": { "week": "17", "matchup": { "franchise": [... } },Week 18 - no matchup element for a skipped week
"schedule": { "weeklySchedule": { "week": "18" } },