Only set -Xjvm-default=all-compatibility on JVM targets

joffrey-bion · Oct 6, 2024 · c0ad71b · c0ad71b
1 parent 45146c1
commit c0ad71b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/gradle/plugins/src/main/kotlin/Targets.kt b/gradle/plugins/src/main/kotlin/Targets.kt
@@ -14,8 +14,13 @@ fun KotlinMultiplatformExtension.allTargets() {
     }
 }
 
+@OptIn(ExperimentalKotlinGradlePluginApi::class)
 fun KotlinMultiplatformExtension.ktorTargets() {
-    jvm()
+    jvm {
+        compilerOptions {
+            freeCompilerArgs.add("-Xjvm-default=all-compatibility")
+        }
+    }
     js {
         browser()
         nodejs {

diff --git a/gradle/plugins/src/main/kotlin/krossbow-multiplatform.gradle.kts b/gradle/plugins/src/main/kotlin/krossbow-multiplatform.gradle.kts
@@ -22,8 +22,13 @@ kotlin {
     }
     compilerOptions {
         progressiveMode = true
-        // we can't enable this yet because of -Xjvm-default=all-compatibility generating a waning on non-JVM
+
+        // We can't enable 'allWarningsAsErrors' yet because of the unique_name warning:
+        // KLIB resolver: The same 'unique_name=org.hildan.krossbow:krossbow-websocket-core' found in more than one library:
+        //   <root>\krossbow-websocket-core\build\classes\kotlin\wasmJs\main,
+        //   <root>\krossbow-websocket-core\build\libs\krossbow-websocket-core-wasm-js.klib
         // allWarningsAsErrors = true
-        freeCompilerArgs.add("-Xjvm-default=all-compatibility")
+
+        // Note: target-specific compiler options are set in the target helpers (see Targets.kt)
     }
 }