made set and get take AsRef<str> #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made the set and get methods on the PKVStore take AsRef<str> so that the user can use types the impl AsRef<str> as an alternative to just &str, this mean you can use and enum and strum to quickly make a key set and no have to worry about spelling mistakes, this also doesn't lock the used into a single type like a generic would and shouldn't break and current used cases outside of calls people using calls to into() or as_ref() to get the same behaviour
|
Oh, and it needs an entry for the example with bevy as a required feature in cargo.toml (that's why the rocksdb ci tests fail) |
forgot to save before comiting
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made the set and get methods on the PKVStore take AsRef so that the user can use types the impl AsRef as an alternative to just &str, this means you can use an enum and strum to quickly make a set of keys and no have to worry about spelling mistakes, this also doesn't lock the user into a single type like a generic would and shouldn't break and currently used cases outside of people using calls to into() or as_ref() to get the same behaviour