Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redb adapter #39

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Add redb adapter #39

merged 3 commits into from
Jun 21, 2023

Conversation

Dimchikkk
Copy link
Contributor

https://github.com/cberner/redb

Add redb adapter and set it as default.

Fixes: #32

@johanhelsing
Copy link
Owner

Oooh, nice!! Looks like just like we want, any drawbacks at all compared to sled?

Implementation looks solid.

@Dimchikkk
Copy link
Contributor Author

Oooh, nice!! Looks like just like we want, any drawbacks at all compared to sled?

Implementation looks solid.

I don't have much knowledge about sled or redb. However, sled doesn't work properly on my M1 laptop when it comes to cleaning data. On the other hand, redb has been functioning as expected so far. A notable advantage of redb is that it stores all the data in a single file, unlike sled which uses multiple files. I consider this an advantage because it facilitates easy sharing of the entire database. If you're interested in the design of redb, you can refer to their documentation at: https://github.com/cberner/redb/blob/master/docs/design.md. It's implemented in pure Rust and doesn't load the entire database into memory. The project appears to be in good health and recently reached version 1.0.0.

@johanhelsing johanhelsing merged commit 45794a4 into johanhelsing:main Jun 21, 2023
@Dimchikkk Dimchikkk deleted the redb branch June 21, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to a maintained rust-based implementation on native
2 participants