-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document all public types #9
Conversation
kinda opinionated also a generic crate level readme.
google is helpful :/ is there is a way to disable doc test for examples? also sorta feel the same way about documenting everything but it really does come down too "feel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“missing-docs”,
Yeah, agree this would be ideal.
src/ui.rs
Outdated
pub cursor_pos: RelativeCursorPosition, | ||
} | ||
|
||
/// bevy ui config for a stick | ||
/// marker component containing `TouchStickId` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure what this component is for anymore. Can we remove it? In any case, "marker" components are generally unit structs (without fields).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can definitely be removed.
I only called it a marker component because of how it appeared to be used.
i did not want too add or remove types/fn with this commit, but if that is acceptable i can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree it's good that this is a pure doc pr
There is
But I don't think we should use it unless we absolutely have to. I think tested or at least compiled doc comments are great. |
applies changes from code review so i can pull locally Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
does this need too be rebased on the most recent commits? pulled from commit im about too push. purposely didnt include because main has other changes docs for TOUCH_GAMEPAD_ID shouldnt include why its u32
|
capitalize first letter in doc items
code consistency
I think this is ready to merge. Furthermore, I did not change the doc comment for TOUCH_GAMEPAD_ID, but I did back-tick the const being used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for all the PRs :)
Since this is internal API (not pub), I think it's good to have it as a doc comment. |
Kinda opinionated, I feel.
Also, a generic crate level README.
I'm a pretty big fan of these Clippy lints:
“missing-docs”,
// less useful for plugins/libraries
// not enabled for this PR
“clippy::missing_docs_in_private_items”
Not intended to be merged just yet, if at all. This is probably the one that's going to need the most refinement.