Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Some vtt.tumblr.com videos are not downloaded if inlined within anothers posts content/body #270

Closed
johanneszab opened this issue Sep 17, 2018 · 0 comments
Assignees

Comments

@johanneszab
Copy link
Owner

johanneszab commented Sep 17, 2018

Currently the inline video regex is new Regex("\"(http[A-Za-z0-9_/:.]*.com/video_file/[A-Za-z0-9_/:.]*)\""); which doesn't detect (already url resolved) inlined tumblr video urls (i.e. from different tumblr video posts). Usually, the self-hosted tumblr videos have an url structure as the following: https://vt.tumblr.com/tumblr_ouv64tPd2n1wai44h{_rX}.mp4 which will not be picked up with the current regex.

@johanneszab johanneszab self-assigned this Sep 17, 2018
@johanneszab johanneszab changed the title vtt.tumblr.com videos are missed if inlined within anothers posts content/body Some vtt.tumblr.com videos are not downloaded if inlined within anothers posts content/body Sep 17, 2018
johanneszab added a commit that referenced this issue Sep 17, 2018
Currently the inline video regex is new Regex("\"(http[A-Za-z0-9_/:.]*.com/video_file/[A-Za-z0-9_/:.]*)\""); which doesn't detect (already url resolved) inlined tumblr video urls (i.e. from different tumblr video posts).
Usually, the self-hosted tumblr videos have an url structure as the following: https://vt.tumblr.com/tumblr_ouv64tPd2n1wai44h{_rX}.mp4 which will not be picked up with the current regex.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant