Skip to content

Commit

Permalink
fix(dingz): [FIX] resolve tilt angle inconsistencies #124
Browse files Browse the repository at this point in the history
- fixes #124
  • Loading branch information
johannrichard committed Nov 22, 2020
1 parent b8d03a8 commit 5df67b9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/dingzAccessory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,6 @@ export class DingzDaAccessory extends EventEmitter {
: 90;
service
.getCharacteristic(this.platform.Characteristic.TargetHorizontalTiltAngle)
// FIXME: #124 remove percentage / angle conversion
.setProps({ minValue: 0, maxValue: maxTiltValue }) // dingz Maximum values
.on(
CharacteristicEventTypes.SET,
Expand Down Expand Up @@ -933,7 +932,6 @@ export class DingzDaAccessory extends EventEmitter {
.getCharacteristic(
this.platform.Characteristic.TargetHorizontalTiltAngle,
)
// FIXME: #124 remove percentage / angle conversion
.updateValue((state.lamella / 100) * maxTiltValue); // Old FW: Set in °, Get in % (...)

let positionState: number;
Expand Down

0 comments on commit 5df67b9

Please sign in to comment.