Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DIP=1 & "not_connected" setting #143

Closed
johannrichard opened this issue Nov 29, 2020 · 1 comment
Closed

[BUG] DIP=1 & "not_connected" setting #143

johannrichard opened this issue Nov 29, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@johannrichard
Copy link
Owner

johannrichard commented Nov 29, 2020

Describe the bug
With the DIP=1 setup and the Dimmers D1 & D2 set to not_connected, one dimmer shows up anyway.

To Reproduce
Steps to reproduce the behaviour:

  1. Set DIP=1
  2. Set both Dimmers to not_connected
  3. Restart homebridge
  4. Single Dimmer shows up (D1/I1)

Expected behaviour
No Dimmer shows up

Originally posted by @granturism0 in #139 (comment)

@johannrichard johannrichard added the bug Something isn't working label Nov 29, 2020
@johannrichard johannrichard self-assigned this Nov 29, 2020
@johannrichard
Copy link
Owner Author

The problem is obviously in the following code (which is part of #118). Working on a fix for this issue. #118 will take a bit more time though.

} else if (
!updatedDingzInputInfo?.active &&
!this.accessory.getServiceById(
this.platform.Service.Lightbulb,
'D1',
) &&
(updatedDingzDeviceInfo.dip_config === 1 ||
updatedDingzDeviceInfo.dip_config === 3)
) {
// Only add Dimmer 0 if we're not in "WindowCover" mode
const dimmerConfig: DingzDeviceDimmerConfig | undefined = this
.device.dimmerConfig;
this.log.warn(
'No Input defined. Attempting to add Dimmer Service D1.',
);
this.addDimmerService({

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant