Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Unit 2 - ConvNext #306

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fixes for Unit 2 - ConvNext #306

merged 2 commits into from
Jul 17, 2024

Conversation

Drakrig
Copy link

@Drakrig Drakrig commented May 18, 2024

  1. Add missing new line in Key Improvements section
  2. Edit Training Techniques section:
  • remove repeated sentences
  • add missing new line before accuracy improvements description

Add missing new line symbol in Key Improvements
c61ffc1 
Edit Training Techniques section:
1. Remove repeated sentences
2. Add new line before last sentence
@Drakrig Drakrig requested a review from merveenoyan as a code owner May 18, 2024 09:37
mmhamdy
mmhamdy approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

johko
johko approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johko johko merged commit 5b8557a into johko:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmhamdy mmhamdy mmhamdy approved these changes

@johko johko johko approved these changes

@merveenoyan merveenoyan Awaiting requested review from merveenoyan merveenoyan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drakrig @johko @mmhamdy