Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy-Editing/Grammatical Fixes: Chapters 2-13 #326

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Copy-Editing/Grammatical Fixes: Chapters 2-13 #326

merged 6 commits into from
Aug 14, 2024

Conversation

ericoulster
Copy link
Contributor

I made small sentence structure changes throughout the course to improve clarity.

Issues are relatively small, and usually involve less than a sentence of revisions across a handful of modules.

mmhamdy
mmhamdy approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the fixes 🙂

@sergiopaniego
Copy link
Collaborator

I can't approve the changes but they look good to me 😄

johko
johko approved these changes Aug 14, 2024
View reviewed changes
Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes 👍 LGTM

johko
johko requested changes Aug 14, 2024
View reviewed changes
Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a little problem in hindsight, I left a comment how to fix it

chapters/en/unit3/vision-transformers/vision-transformer-for-object-detection.mdx Show resolved Hide resolved
johko
johko approved these changes Aug 14, 2024
View reviewed changes
Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response 👍

@johko johko merged commit c3f6f7e into johko:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmhamdy mmhamdy mmhamdy approved these changes

@sergiopaniego sergiopaniego sergiopaniego approved these changes

@johko johko johko approved these changes

@merveenoyan merveenoyan Awaiting requested review from merveenoyan merveenoyan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericoulster @sergiopaniego @johko @mmhamdy