Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE PR knowledge distillation #349

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

ghassen-fatnassi
Copy link
Contributor

we already discussed the changes , this is just because of the merge conflict

@ghassen-fatnassi
Copy link
Contributor Author

@mmhamdy @johko

Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks! 😀

@ghassen-fatnassi
Copy link
Contributor Author

same problem as before : issue link

Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it 🙏 and sorry for the extra work of creating a new PR

@johko
Copy link
Owner

johko commented Oct 7, 2024

same problem as before : issue link

Yeah, sorry about that. The error has been existing for a while and I'm trying my best to fix it, but I think it is related to an access token I cannot generate, but only people from the HF core team. I wasn't really successful in getting an answer from anyone yet though. But I will merge the PR anyway and as soon as the error is fixed, it will show in the course on the website.

@johko johko merged commit 0e4eced into johko:stage Oct 7, 2024
2 checks passed
@ghassen-fatnassi
Copy link
Contributor Author

thanks a lot man , I'm really motivated to share any knwoledge i acquire in the future <3
thanks for your time !

@ghassen-fatnassi ghassen-fatnassi deleted the patch-1 branch October 7, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants