fixbug: Add description to keymaps #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johmsalas
added a commit
that referenced
this pull request
Jun 9, 2022
akinsho
reviewed
Jun 9, 2022
| } | ||
|
|
||
| pcall( | ||
| require("which-key").register, |
There was a problem hiding this comment.
@johmsalas I think this is probably why you had issues, this function always requires which key even if it is inside a pcall because rather than wrapping the require you wrap the register.
This should be local ok, whichkey = pcall(require, 'which-key') then if ok is true then use register
There was a problem hiding this comment.
🤯 I'm realizing you are a ninja.
If I could give you a review that you'd be "empowers others"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds description to the keybindings
WhichKey
Telescope
TODO:
[ ] Sort which key mappings (Should create a different issue)
[ ] Show key mappings for partial keys, like
gaandgao(Should create a different issue)[ ] Clean up after finding out
vim.keymap.set('n', '<key>', lua_func, {desc = 'this is what I do'})does almost all the job