Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #308, indicate that md5 is not used in a security context #309

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix #308, indicate that md5 is not used in a security context #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tldextract/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,14 @@ def get_pkg_unique_identifier() -> str:

tldextract_version = "tldextract-" + version
python_env_name = os.path.basename(sys.prefix)
md5_kwargs: dict[str, Hashable] = {}
# for python >= 3.9, indicate that md5 is not used in a security context
if sys.version_info >= (3, 9):
md5_kwargs = {"usedforsecurity": False}
# just to handle the edge case of two identically named python environments
python_binary_path_short_hash = md5(sys.prefix.encode("utf-8")).hexdigest()[:6]
python_binary_path_short_hash = md5(
sys.prefix.encode("utf-8"), **md5_kwargs
).hexdigest()[:6]
python_version = ".".join([str(v) for v in sys.version_info[:-1]])
identifier_parts = [
python_version,
Expand Down