VIX-3570 Fixing bug with concurrent fan mode and updating defaults

johncbaur · Aug 31, 2024 · 965bc70 · 965bc70
1 parent ee06d22
commit 965bc70
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/Vixen.Modules/Effect/LineDance/LineDanceData.cs b/src/Vixen.Modules/Effect/LineDance/LineDanceData.cs
@@ -29,14 +29,14 @@ public LineDanceData()
 			// Set the Pan Start Angle to -1 to cause the effect to calculate a default value
 			PanStartAngle = -1;
 
-			// Default the pan increment to 80%
-			PanIncrement = 80;
+			// Default the pan increment to 20%
+			PanIncrement = 20;
 
-			// Default the speed to 40%
-			PanSpeed = 40;
+			// Default the speed to 30%
+			PanSpeed = 30;
 
-			// Default the hold time to 10%
-			HoldTime = 10;
+			// Default the hold time to zero
+			HoldTime = 0;
 		}
 
 		#endregion

diff --git a/src/Vixen.Modules/Effect/LineDance/LineDanceModule.cs b/src/Vixen.Modules/Effect/LineDance/LineDanceModule.cs
@@ -1069,7 +1069,15 @@ private int CalculatePanIncrement()
 		{
 			// Taking the PanIncrement slider value and applying it to a max value of 50
 			// since this will be applied to Mid value of 50
-			return (int)((PanIncrement / 100.0) * 50);
+			int panIncrement = (int)((PanIncrement / 100.0) * 50);
+
+			// Don't allow the pan increment to be zero
+			if (panIncrement == 0)
+			{
+				panIncrement = 1;
+			}
+
+			return panIncrement;
 		}
 
 		/// <summary>