Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make export default class the main file class in GDScript, add support for subclasses #61
base: main
Are you sure you want to change the base?
Make export default class the main file class in GDScript, add support for subclasses #61
Changes from 15 commits
946cb1e
ddcea40
2753c88
b558ecd
5b3418e
6687a9c
5894a26
a544f34
1e9f87f
bf51a77
1825ef2
e72f177
8381679
6030bc9
ff497da
c80d179
c1f59dd
f44ae4e
fc82ee2
060ec33
b43f26c
ced47d7
e1ea6f2
b98306f
630d5ef
a61f720
751e2ee
4f65188
63756f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .() at the end seems incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that a base constructor is called (here are docs). If base constructor does not have arguments
.()
can be omitted. Why is it wrong? Does this code not compile or is wrongly generated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know it looks weird but it really is valid GD syntax!