Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve std feature flag in README #66

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 14, 2024

Sorry, my previous example was hardcoded for std, but in theory this flag could be used also for core/alloc, if some people want to only rebuild these libstd crates. Using just optimize_for_size should be more rgeneral.

@johnthagen
Copy link
Owner

Could you also fix this in the GitHub actions that uses this flag for nightly tests?

Sorry, my previous example was hardcoded for `std`, but in theory this flag could be used also for core/alloc, if some people want to only rebuild these libstd crates. Using just `optimize_for_size` should be more rgeneral.
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 16, 2024

Sure thing, done!

@johnthagen johnthagen self-assigned this Jun 17, 2024
@johnthagen johnthagen added the enhancement New feature or request label Jun 17, 2024
@johnthagen johnthagen merged commit 2f7d968 into johnthagen:main Jun 17, 2024
16 checks passed
@johnthagen
Copy link
Owner

Thank you for your contribution, @Kobzol.

@Kobzol Kobzol deleted the patch-1 branch June 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants