Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4/5 compatibility #131

Closed
1 task done
JetForMe opened this issue Apr 3, 2019 · 4 comments
Closed
1 task done

Swift 4/5 compatibility #131

JetForMe opened this issue Apr 3, 2019 · 4 comments

Comments

@JetForMe
Copy link

JetForMe commented Apr 3, 2019

Please help prevent duplicate issues before submitting a new one:

  • I've searched other open/closed issues for duplicates before opening up this new issue.

Report

I'm trying to use Carthage to include Down in my Xcode 10.2/Swift 5 project. But the Down project specifies Swift 4, and I get incompatibility errors when trying to compile/link against it.

What did you do?

Created a new Swift 5 project. Set up Carthage to include Down. Compiled, got an error "The following binaries use incompatible versions of Swift:" referencing my app and the Down framework.

What did you expect to happen?

This is going to be tricky, isn't it? I need to be able to compile dependencies with Swift 5 via Carthage. I tried modifying the project, and it builds and the tests pass, but if I update with Carthage it reverts to Swift 4.

What happened instead?

if I update with Carthage it reverts to Swift 4. Need a version that bumps the Swift version, but there's a backward-compatibility issue.

@iwasrobbed
Copy link
Collaborator

iwasrobbed commented Apr 3, 2019 via email

@JetForMe
Copy link
Author

JetForMe commented Apr 3, 2019

For sure, until they need features or bugfixes you offer but need pre-Swift-5 compatibility. I'm all for staying on the bleeding edge, but I think this is a problem that's going to affect a lot of Carthage projects (or really, any project that uses third-party libraries).

@JetForMe
Copy link
Author

JetForMe commented Apr 5, 2019

I'm conflating the Swift 5 compiler version with the selected language dialect. All we need is to use the Swift 5 compiler; we don't need to change the setting inside the Xcode project. So, building from source via Carthage should work just fine, once everything is set up properly.

@JetForMe JetForMe closed this as completed Apr 5, 2019
@iwasrobbed
Copy link
Collaborator

Updating to Swift 5.0 in #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants