[cmark] Update lib to v0.28.3 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmark was pulled from tag 0.28.3 from the cmark GitHub project.
Had to remove header "cmark.h" line because of duplicate symbol errors. Apparently when the headers are imported through this file the include guards are not honored.
|
The travis build failed with xCode 9 but succeeds with xCode 10.1. I have 10.1 locally. The failure was an "ambiguous reference" error when compiling one of the cmark files. Not sure what needs to be done. |
iwasrobbed
approved these changes
Nov 10, 2018
There was a problem hiding this comment.
@phoney This looks great and I appreciate you tackling this one 👍 I'm fine with having Xcode 10.1 be the release IDE since it's stable now
Could you write a quick "How to update cmark" wiki that we can have as a reference for others in the future? I'm trying to hand over some responsibilities to the community where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmark code was updated to version 0.28.3 from that tag in the cmark repo.
I needed to update the module.modulemap file due to duplicate symbol errors.
No files were added or removed.