Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Swift version 4.0 in podspec #140

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Set Swift version 4.0 in podspec #140

merged 1 commit into from
Apr 24, 2019

Conversation

larryonoff
Copy link
Contributor

@larryonoff larryonoff commented Apr 23, 2019 •
edited by iwasrobbed
Loading

Closes #139

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.953% when pulling dc09e0a on larryonoff:podspect-swift into 4c35c7b on iwasrobbed:master.

iwasrobbed
iwasrobbed approved these changes Apr 24, 2019
View reviewed changes
Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larryonoff 👍

@iwasrobbed iwasrobbed merged commit 3d044c7 into johnxnguyen:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwasrobbed iwasrobbed iwasrobbed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.7.0 problems with NSAttributedString.Key
3 participants
@larryonoff @coveralls @iwasrobbed