Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cmark to 0.29.0 #142

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Conversation

larryonoff
Copy link
Contributor

@larryonoff larryonoff commented Apr 23, 2019

@coveralls
Copy link

coveralls commented Apr 23, 2019

Coverage Status

Coverage remained the same at 92.953% when pulling e6bf581 on larryonoff:bump-cmark-0.29.0 into 3d044c7 on iwasrobbed:master.

@iwasrobbed
Copy link
Collaborator

Hi @larryonoff 👋 Thanks for these changes

Did you happen to follow the wiki to update these?

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, looks good 👍 I'll take care of adding the new option and updating docs

(Just an FYI: I took a quick diff of these changes against the cmark repo since I'm hesitant to allow others to update cmark for security reasons)

* raw HTML is replaced by a placeholder HTML comment. Unsafe
* links are replaced by empty strings.
*/
#define CMARK_OPT_UNSAFE (1 << 17)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add this to the DownOptions and update the documentation for CMARK_OPT_SAFE since this behavior changed in v0.29.0 (it used to pass through raw HTML and now it doesn't)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for mentioning and fixing this :)

@iwasrobbed iwasrobbed merged commit 25fde3d into johnxnguyen:master Apr 24, 2019
@iwasrobbed
Copy link
Collaborator

Released as v0.8.0 🚀

@larryonoff
Copy link
Contributor Author

@iwasrobbed

Hi @larryonoff 👋 Thanks for these changes

Did you happen to follow the wiki to update these?

It looks that the guide is outdated. cmark has number of files that are used to generate the code. These generated files are in Down repo, e.g. cmark_version.h.in.

@larryonoff larryonoff deleted the bump-cmark-0.29.0 branch April 25, 2019 05:58
@phoney
Copy link
Contributor

phoney commented Apr 29, 2019

@larryonoff @iwasrobbed - Yes, but those files didn't change when I updated the cmark version last time. Frankly, those files are an annoyance for us because we can't use them directly or in an automated way. If those files did change and you made updates due to that, the wiki could be updated to explain what to do in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants