Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configurability of DownStyler #188

Merged
merged 5 commits into from
Nov 12, 2019
Merged

Improve configurability of DownStyler #188

merged 5 commits into from
Nov 12, 2019

Conversation

mgacy
Copy link
Contributor

@mgacy mgacy commented Nov 8, 2019

Extends configurability of DownStyler and extends #184

  • adds public, memberwise initializers for styling options
  • adds public, memberwise initializers for DownStylerConfiguration
  • makes ParagraphStyleCollection a protocol and adds StaticParagraphStyleCollection to match other attribute collections
  • makes properties and methods of ListItemParagraphStyler public

Copy link
Collaborator

@iwasrobbed-ks iwasrobbed-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there @mgacy

Thanks for the changes 👍 This is definitely a deficiency in Swift at the moment. Swift 5.1 autogenerates inits with defaults but then if you want a public init then you have to implement it yourself :\ (see Default Memberwise Initializers for Structure Types)

👉 Please fix the broken tests before this can get merged.

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #188 into master will decrease coverage by 3.38%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   35.98%   32.59%   -3.39%     
==========================================
  Files          54       74      +20     
  Lines        1070     2362    +1292     
==========================================
+ Hits          385      770     +385     
- Misses        685     1592     +907
Impacted Files Coverage Δ
...tribute Collections/ParagraphStyleCollection.swift 0% <ø> (ø) ⬆️
Source/AST/Styling/Options/ListItemOptions.swift 0% <0%> (ø)
...ource/AST/Styling/Options/QuoteStripeOptions.swift 0% <0%> (ø)
.../AST/Styling/Helpers/ListItemParagraphStyler.swift 0% <0%> (ø) ⬆️
.../AST/Styling/Stylers/DownStylerConfiguration.swift 0% <0%> (ø) ⬆️
Tests/Styler/StylerTestSuite.swift 0% <0%> (ø)
Source/AST/Styling/Options/CodeBlockOptions.swift 0% <0%> (ø)
...rce/AST/Styling/Options/ThematicBreakOptions.swift 0% <0%> (ø)
Tests/Styler/LinkStyleTests.swift 0% <0%> (ø)
Tests/Styler/HeadingStyleTests.swift 0% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99cbca...90341e2. Read the comment docs.

@iwasrobbed
Copy link
Collaborator

@johnxnguyen Any objections here?

Copy link
Owner

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this @mgacy .

@iwasrobbed iwasrobbed merged commit cd1a3f6 into johnxnguyen:master Nov 12, 2019
@mgacy mgacy deleted the hotfix/public-initializers branch December 18, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants