-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve configurability of DownStyler #188
Improve configurability of DownStyler #188
Conversation
Make ParagraphStyleCollection a protocol and add StaticParagraphStyleCollection struct conforming to protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there @mgacy
Thanks for the changes 👍 This is definitely a deficiency in Swift at the moment. Swift 5.1 autogenerates inits with defaults but then if you want a public
init then you have to implement it yourself :\ (see Default Memberwise Initializers for Structure Types)
👉 Please fix the broken tests before this can get merged.
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 35.98% 32.59% -3.39%
==========================================
Files 54 74 +20
Lines 1070 2362 +1292
==========================================
+ Hits 385 770 +385
- Misses 685 1592 +907
Continue to review full report at Codecov.
|
@johnxnguyen Any objections here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this @mgacy .
Extends configurability of
DownStyler
and extends #184DownStylerConfiguration
ParagraphStyleCollection
a protocol and addsStaticParagraphStyleCollection
to match other attribute collectionsListItemParagraphStyler
public