Swift 5.1 Support #204
Merged
Swift 5.1 Support #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Mar 3, 2020
| @@ -1 +0,0 @@ | |||
| 5.0 | |||
There was a problem hiding this comment.
This file has been deprecated by CocoaPods.
ghost
commented
Mar 3, 2020
| @@ -19,5 +19,5 @@ Pod::Spec.new do |spec| | |||
| spec.pod_target_xcconfig = { 'SWIFT_INCLUDE_PATHS' => '$(SRCROOT)/Down/Source/cmark/**' } | |||
| spec.ios.resource = 'Resources/DownView.bundle' | |||
| spec.osx.resource = 'Resources/DownView.bundle' | |||
| spec.swift_version = "5.0" | |||
There was a problem hiding this comment.
This reflects additional CocoaPods evolution.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 32.59% 32.59%
=======================================
Files 74 74
Lines 2362 2362
=======================================
Hits 770 770
Misses 1592 1592 Continue to review full report at Codecov.
|
iwasrobbed
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
I updated the example app project settings as well, thanks again @stevebaranski 💯
1 task
|
@iwasrobbed good catch - thank you! |
regennz
pushed a commit
to regennz/Down
that referenced
this pull request
Apr 14, 2020
* Updated project for Swift 5.1 support * Updated xcconfig files & removed superfluous project overrides * [Example] Update example app settings Co-authored-by: rob phillips <rob@robphillips.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request proposes a solution for #178, which requested that
Downsupport Swift 5.1.Details
This PR consists of two commits:
.xcconfigfiles were being overridden in the Xcode project configuration (i.e., Build Settings). I took the liberty to address this withSWIFT_VERSION, then made similar changes forDEPLOYMENT_TARGET. I also removed the watchOS references, as it doesn't appear that the framework supports that.Testing
The branch should build & tests should pass.