Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Bump swift snapshot testing to 1.7.2 #216

Merged
merged 6 commits into from
Jun 12, 2020

Conversation

johnxnguyen
Copy link
Owner

What's in this PR?

This PR updates the swift snapshot testing dependency to 1.7.2 for Xcode 11.4 support.

@iwasrobbed-ks iwasrobbed-ks self-requested a review June 11, 2020 14:28
Copy link
Collaborator

@iwasrobbed-ks iwasrobbed-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this will need an Xcode bump in .travis.yml

Module compiled with Swift 5.2.2 cannot be imported by the Swift 5.1 compiler: /Users/travis/build/iwasrobbed/Down/Carthage/Build/iOS/SnapshotTesting.framework/Modules/SnapshotTesting.swiftmodule/x86_64-apple-ios-simulator.swiftmodule

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #216 into master will decrease coverage by 1.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   70.07%   68.63%   -1.45%     
==========================================
  Files          74       74              
  Lines        2042     2047       +5     
==========================================
- Hits         1431     1405      -26     
- Misses        611      642      +31     
Impacted Files Coverage Δ
Tests/Styler/StylerTestSuite.swift 98.86% <100.00%> (+0.01%) ⬆️
...tyling/Attribute Collections/ColorCollection.swift 0.00% <0.00%> (-100.00%) ⬇️
...Styling/Attribute Collections/FontCollection.swift 0.00% <0.00%> (-90.91%) ⬇️
.../AST/Styling/Helpers/ListItemParagraphStyler.swift 67.50% <0.00%> (-7.50%) ⬇️
...yler/Helpers/NSAttributedString+HelpersTests.swift 0.00% <0.00%> (ø)
...rs/NSMutableAttributedString+AttributesTests.swift 0.00% <0.00%> (ø)
Source/AST/Visitors/AttributedStringVisitor.swift 91.52% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2a448...b0ed0aa. Read the comment docs.

@iwasrobbed iwasrobbed merged commit c389ca6 into master Jun 12, 2020
@iwasrobbed iwasrobbed deleted the chore/update-snapshot-test-depedency branch June 12, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants