-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create custom sequence to access child nodes #228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 68.63% 68.68% +0.04%
==========================================
Files 74 75 +1
Lines 2047 2047
==========================================
+ Hits 1405 1406 +1
+ Misses 642 641 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in the review, I started this a few days ago but forgot to submit.
For me it is good, just want to check with @iwasrobbed-ks regarding the breaking change to DownASTRenderable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small tweaks, otherwise looks good! Thanks @5sw
Thanks again @5sw 🎉 |
Also add a method to directly return the Document from DownASTRenderable.