Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add arm64 as valid arch when building for simulator on M1 macs #249

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

michaelknoch
Copy link
Contributor

this pr allows building and linking Down when running on arm64 simulator

Error message without this:

Could not find module 'Down' for target 'arm64-apple-ios-simulator'; found: x86_64-apple-ios-simulator, x86_64

@michaelknoch
Copy link
Contributor Author

@johnxnguyen

@johnxnguyen
Copy link
Owner

Hey @michaelknoch , thanks for the contribution! Do you know if a similar solution is needed when Down is pulled in via Swift Package Manager?

@johnxnguyen johnxnguyen changed the title add arm64 as valid arch when building for simulator on M1 macs [Chore] Add arm64 as valid arch when building for simulator on M1 macs Feb 26, 2021
@michaelknoch
Copy link
Contributor Author

I think exactly this change is needed when fetching Down via SPM for running an ios application on an arm64 simulator, but I haven't tried it. We are fetching Down as a git submodule and embedding it directly into the xcode project. I was wondering if it would make sense to get rid of the VALID_ARCHS variable entirely. Xcode should be able to set the ARCHS variable (which is basically the same) automatically. @johnxnguyen

@johnxnguyen
Copy link
Owner

I was wondering if it would make sense to get rid of the VALID_ARCHS variable entirely. Xcode should be able to set the ARCHS variable (which is basically the same) automatically.

@michaelknoch unfortunately I don't have an M1 laptop so can't really say what works or doesn't work. If this PR solves the issue for you, I'm happy to to approve it.

@michaelknoch
Copy link
Contributor Author

It does definitely solve the build errors when building for an arm64 simulator on an M1 mac @johnxnguyen

Copy link
Owner

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @michaelknoch

@johnxnguyen johnxnguyen merged commit 4c1c888 into johnxnguyen:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants