#6 macOS Support #25
#6 macOS Support #25
Conversation
|
Changes Unknown when pulling 58a4249 on 128keaton:master into ** on iwasrobbed:master**. |
|
Thanks @128keaton ! Mind describing the project changes real quick? Might be easier than me trying to visually see what's changed |
|
@iwasrobbed I actually changed very little. I added a new Target for macOS, then just allowed 'ownership' of the needed files to the target. I shimmed code in two files to allow the compiler to use the correct frameworks for each platform, and the correct line of code to open the URL. Here was the correction for the URL opening: https://github.com/iwasrobbed/Down/blob/58a4249f8f22fa51d9d3bbbca499c57f80ae46a7/Source/Views/DownView.swift#L101 And for the string extension: Lastly, looks like Xcode automatically updated some naming schemes to conform, I couldn't make the framework's name 'Down-macOS' because the dash made Xcode lash out. That and the basic file changes covers MOST of the 'major' changes according to git. |
|
Changes Unknown when pulling 642972a on 128keaton:master into ** on iwasrobbed:master**. |
|
err I didn't want those to be pulled..wtf Github. |
|
Thanks @128keaton! (btw, you'd need to fork your local branch if you don't want that commit showing up here; otherwise, any commit to your |
|
I think the 642972a commit is fine to keep, I'll have a look later |
There was a problem hiding this comment.
The only thing I see missing is a new test target for the macOS path.
- Here's an example if you wouldn't mind adding and making sure it passes locally before committing your
.travis.ymlchanges
Down's .travis.yml file is in the root dir: https://github.com/iwasrobbed/Down/blob/master/.travis.yml
|
@iwasrobbed okay I'll see if I can figure it out. I've never used tests or travis before. If anyone else who knows how to write tests just makes the changes in their branch I'll close this request and you can use theirs |
|
@128keaton Ah no worries, no need to write new tests most likely (we just need to execute the existing tests against your new macOS target). The best thing to do is just run that tests command locally on your Existing iOS test command: set -o pipefail && xcodebuild test -project Down.xcodeproj -scheme "Down-iOS" -destination "platform=iOS Simulator,name=iPhone 5,OS=9.3" -enableCodeCoverage YES ONLY_ACTIVE_ARCH=YES | xcpretty -cI imagine the macOS version would look like set -o pipefail && xcodebuild test -project Down.xcodeproj -scheme "Down-macOS" -sdk macosx -destination "platform=OS X,arch=x86_64" -enableCodeCoverage YES ONLY_ACTIVE_ARCH=YES | xcpretty -cIf that works locally on your computer, we hopefully shouldn't have problems just appending it to our Does that help clarify it? |
|
@iwasrobbed well I can't get OS X tests to run, at all, |
|
Okay, I created a tests target for OS X (oops) and the command works if I specify the testing scheme. |
|
@128keaton Welcome to the fun (but necessary) world of testing :) If things are working as planned, feel free to add that new command to the travis script and commit the changes and the PR will re-run w/ those tests |
|
Yup. I need to start doing this with all of my projects. Currently learning Travis. Let me check it out and I'll push the test branch |
* Created two new Targets * Updated .travis.yml file * Updated schemes for testing * Update Down.podspec
|
Lets see if this works! |
|
Changes Unknown when pulling c1ff17e on 128keaton:master into ** on iwasrobbed:master**. |
|
Travis is really finicky and looks like it errored out for internal reasons, so I restarted the build to see if it'd clear itself 🍿 👀 |
|
Changes Unknown when pulling c1ff17e on 128keaton:master into ** on iwasrobbed:master**. |
|
Look at that, worked like a charm. Thanks again (and also thanks for your patience & for rebasing) @128keaton ! |
|
Yeah haha don't worry about it. Glad it works! |
Adds support for macOS (resolves #6)