[Pods] Only include files in source_files that can be compiled

[njdehoog]

These warnings are thrown by the compiler when including Down as a cocoapod:

By excluding files that should not be compiled from spec.source_files, we can prevent those warnings.

[coveralls]

Coverage remained the same at 47.923% when pulling f1ea78c on njdehoog:fix_spec into 4082c8d on iwasrobbed:master.

[iwasrobbed]

Hi @njdehoog 👋 Unfortunately we cannot merge this change, but there is a fix you can apply here as well as more information: #26

[njdehoog]

hi @iwasrobbed, thanks for your response! I've read through the thread you linked to but I don't fully understand the reasoning. These are valid warnings that Xcode is throwing, so why not fix them in the podspec? I've tested this with my fork and it compiles/runs fine. We could add the COPYING file to preserve_paths if this is about licensing.

[iwasrobbed]

Sorry for the delayed reply! If you can get all files to still be included, it compile fine and integrate fine into an example project as well as get pod lib lint passing, I'm happy to have another look!

[njdehoog]

Sure thing. I'm having some trouble getting pod lib lint to pass, even on master, but I will look into it when I have some more time. Could you reopen the PR so the changes become visible?

[iwasrobbed]

Try pod spec lint or pod spec lint --allow-warnings (if it's a C code warning) as well; for some reason one of them works and the other never has

[njdehoog]

Thanks for the advice. I made a change to preserve all the files, and I verified that pod spec lint succeeds and that I can include the pod in a sample project. pod spec lint still throws 1 warning, but that was a pre-existing one.

[iwasrobbed]

Thanks again @njdehoog ! I'll have a quick look in the morning and merge if all looks 👍

[iwasrobbed]

Just ran a quick integration test and this looks great. Thanks again @njdehoog !

[iwasrobbed]

Released to v0.5.2 here: #87

Thanks again!

[njdehoog]

You're welcome. Thanks for getting this released!