support embed command in dotenv file #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO it would be best if this were an opt-in feature, since this can open up all kinds of security risks! |
|
Agreed. |
|
So how about I do it this way: godotenv.EnableEmbed()
godotenv.Load()If we don't |
durandj
reviewed
Apr 19, 2019
| if strings.HasPrefix(value, "$(") && strings.HasSuffix(value, ")") { | ||
| cmdStr := value[2 : len(value)-1] | ||
| cmd := exec.Command("/bin/sh", "-c", cmdStr) | ||
| out, _ := cmd.Output() |
There was a problem hiding this comment.
Why silence the error here? Wouldn't that make it harder to diagnose failures?
durandj
reviewed
Apr 19, 2019
| if shouldParseEmbed { | ||
| if strings.HasPrefix(value, "$(") && strings.HasSuffix(value, ")") { | ||
| cmdStr := value[2 : len(value)-1] | ||
| cmd := exec.Command("/bin/sh", "-c", cmdStr) |
There was a problem hiding this comment.
Shouldn't you do a check for the OS here and if on Windows create a PowerShell session?
|
@durandj @DarthPestilane seeing as it looks like this went stale, I've addressed the comments / concerns and opened a new PR #230 |
|
Closing per #182 but thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support embed commands via
$()(not supported on Windows)Note that using $() might not work depending on your shell.