Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that keeps Send page from loading while there's an ongoing collaborative transaction #246

Closed
ghost opened this issue May 10, 2022 · 2 comments · Fixed by #300
Closed

Fix issue that keeps Send page from loading while there's an ongoing collaborative transaction #246

ghost opened this issue May 10, 2022 · 2 comments · Fixed by #300
Assignees
@theborakompanioni
Labels
bug Something isn't working
Milestone
v0.0.7 - Sticky Jam

Comments

@ghost
Copy link

ghost commented May 10, 2022

See #242.

The Send page never finishes loading while there's an ongoing transaction schedule.
@ghost ghost added the bug Something isn't working label May 10, 2022
@theborakompanioni
Copy link
Collaborator

See #242.

The Send page never finishes loading while there's an ongoing transaction schedule.

I just know realized this is true for single collaborative transactions as well. Might be a regression in the server repo, but needs verification – no response from the configget endpoint. (We should not really need to fetch this value everytime anyway – lots of room for improvement in the future).

@ghost
Copy link
Author

ghost commented May 11, 2022

Damn. Is this something you could look into maybe?

@ghost ghost added this to JAM May 11, 2022
@ghost ghost added this to the v0.0.6 - Cooking Timer milestone May 11, 2022
@ghost ghost changed the title Fix issue that keeps Send page from loading during scheduled transactions Fix issue that keeps Send page from loading while there's an ongoing collaborative transaction May 11, 2022
@theborakompanioni theborakompanioni self-assigned this May 11, 2022
@ghost ghost moved this to Todo 📝 in JAM May 18, 2022
@theborakompanioni theborakompanioni mentioned this issue May 30, 2022
Merged
@ghost ghost closed this as completed in #300 Jun 2, 2022
Repository owner moved this from Todo 📝 to Done ✅ in JAM Jun 2, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theborakompanioni theborakompanioni

Labels
bug Something isn't working
Projects
JAM
Status: Done ✅
Milestone
v0.0.7 - Sticky Jam
Development

Successfully merging a pull request may close this issue.

fix: loading state on Send page joinmarket-webui/jam
2 participants
@dergigi @theborakompanioni