-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loading state on Send page #300
Conversation
e44d9a5
to
753ddab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed, that is modeled after the screens in Figma. Just disabled when taker is running, additionally blurred when maker is running. The reason for this is, I think, that the taker operation is started from this screen and the input values could potentially still be displayed (which is currently not the case). |
I'd say let's not make this too complex and forward looking and just go with a single style here. What do you think? |
for send page while collaborative tx active: the idea is the user revisits the send page and sees the values that were chosen, thus its disabled but visible: for this idea to work its needed to see actual values inside the blocked/disabled form for send page while earn/ jam active: it should show the user, that a complete different process from another page is active thus the complete form is unreadable, the situation is "heavier" these are details at the end and I think we will concentrate on visual consistency later on, what do you think? |
I have created another PR where the whole form is blurred if a taker or maker operation is running. If the whole form should be blurred, apply the PR, if it is okay the way it is, just close it. |
5a677f9
to
070249b
Compare
Ah I see. Thanks for the explanation -- I can see now where that differentiation can make sense. The thing is that at the moment we don't differentiate between a single collaborative transaction and the scheduler. That means the send page will not be blurred when the scheduler is running (see screenshots). That's why I'd say let's hold off with making that distinction for now and go with a consistent UI until we can actually implement the desired behavior. Does that make sense? |
Closes #246.
Infer the loading state based on whether the component is "initializing" or is "waiting" for something.
The distinction has been made in order to separate between "service is enabled, but loading" and "service is disabled, but loading". Before this commit, the loading flag has never been reset if the service was disabled.
Furthermore, with this commit, the behaviour when "waiting for utxos to be reported as spent" is consistent. Service is disabled and loading flag is
true
.Service is disabled if one of these conditions is met: