-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cheatsheet #211
feat: add cheatsheet #211
Conversation
43aeaa6
to
4bddaed
Compare
458a233
to
8b9679a
Compare
Footer |
thanks for the update. i added a "close" button and changed icon to the "file" icon from bitcoinicons. valid point for mobile use. some thoughts: would love to see the cheatsheet jump up once fully automatically after a delay when the user uses JAM for the first time, directly after the creation of the first wallet (see rapid prototype, flow "empty wallet" for a better understanding, press R to reset prototype). the underlined words are links, the first 3 links in the text are linking to openoms sources and the other links are linking to parts inside the jam app. i.e.: (1) Fund your wallet first. (click it inside the prototype) also its better to hide "cheatsheet" in the footer until the user created the first wallet (if easy and possible). just to not confuse too much at the beginning. I gave point 4 fidelity bond another color to show its inactive for now, but never the less, there are some informations that enlightens the user. maybe its a good idea to also communicate the upcoming feature FB |
src/components/Cheatsheet.tsx
Outdated
return <div className="numbered">{number}</div> | ||
} | ||
|
||
function ListItem({ number, children }: PropsWithChildren<NumberedProps>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can take this one step further
interface ListItemProps {
number: number
transaltionKey: string
descriptionKey: string
}
function ListItem({ number, children, transaltionKey, descriptionKey }: PropsWithChildren<ListItemProps>) {
const { t } = useTranslation()
return (
<rb.Stack className="cheatsheet-list-item" direction="horizontal" gap={3}>
<div className="numbered">{number}</div>
<rb.Stack gap={0}>
<h6>
<Trans i18nKey={transaltionKey}>{children}</Trans>
</h6>
<div className="small text-secondary">{t(descriptionKey)}</div>
</rb.Stack>
</rb.Stack>
)
}
<ListItem number={1} transaltionKey="cheatsheet.item_1.title" descriptionKey="cheatsheet.item_1.description">
<Link to="/receive">Fund</Link> your wallet first.
</ListItem>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing translation keys strikes me as unnecessarily restrictive.
It is so little code - feels like over-engineering to me for now. Do not get me wrong - I love to over-engineer.. : D
But feel free to add any improvements once the PR is merged!
2b887ba
to
524848a
Compare
Co-authored-by: Đorđe Spasić <34274884+Djo1e@users.noreply.github.com>
Updated screenshots. |
Done. Will be shown once after a wallet has been unlocked, just like the onboarding screen.
👍
It will be displayed only if a wallet is unlocked - not on the login screen (links would not work).
👍 Done. Opacity decreased for item 4. Edit: The feature is still disabled by default for now - should it be enabled once scheduled transactions are supported? |
All honor to @editwentyone.
I am always grateful for concrete wording suggestions, because there are so many people who have the necessary talent for this - but I am afraid I am not one of them.
Changed from "add more noise" to "increase privacy of all". "noise" is avoided entirely. It is not used anywhere and would - like you said - need an explanation. Acceptable approach?
Since we use the term "sweep" on the Send screen also, do you think it can be explained there and is this the appropriate context? Refrained from changing anything in the cheatsheet component regarding this for now.
👍 "more private" it is.
Yep, that is true. Maybe also better explained on the "Earn" screen, when the context is appropriate (?).
One question before it is merged - should item 3 and 4 be flipped? |
I'd say yes. Another thing that touches on something that we discussed often—something that isn't fully resolved yet—is the mentioning of "levels." If we manage to implement and ship #179 with the next release, manual consolidation (and thus anything that mentions "levels" at all) might fall to the wayside for most users, since this would be automated with scheduled transactions. I'll propose some wording changes in the code directly. |
Co-authored-by: Gigi <109058+dergigi@users.noreply.github.com>
Co-authored-by: Gigi <109058+dergigi@users.noreply.github.com>
I just noticed that there are two sources of truth for the text due to the translation engine, so I will just type it out here before I propose code changes that might be misplaced: The Cheatsheet Follow the steps below to increase your financial privacy. It is advisable to switch from earning as a maker to sending as a taker back and forth. Learn more. 1) Fund your wallet. 2) Send a collaborative transaction to yourself. 3) Optional: Lock funds in a fidelity bond. 4) Provide liquidity and earn yield. 5) Make use of scheduled transactions 6) Go to step one and repeat. This assumes that we will ship #179 soon, which I think we will. I'm an optimist! 😁 Let me know what you think. |
Ah, yes, totally forgot that fact when applying the suggestions before.
Yes. Worst case is, we have to apply css class
I'd merge it! Ping @editwentyone for a competent design perspective. |
hey :) because on mobile its a lot of text, I would suggest to fix the Numbers at the top of the cell, I also fixed it in Figma. also I would suggest to link only the important words like Fund, Send, Earn, it reads faster |
👍 Done.
👍 Done.
|
Love it! One final suggestion from my side:
This way it reads fund / send / earn / schedule. Great suggestions Edi, and great job implementing all this tbk! 🧡 |
fc7ca9f
to
37f1e9b
Compare
Looks and reads even better! The latest changes also contain the most basic support for simple Feature Flags. Will merge this as soon as it is approved, but please do not hold back in case anyone still comes up with suggestions or feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✅
one little annoyance: by clicking a link like "Fund", its switching the page in the background and keeps the cheatsheet still in the front. could we close the cheatsheet also with the same click? (+ is it possible to overlay the complete page including the header when the cheatsheet is active?) |
I thought of that as a feature instead of a bug : D
This is a little bit trickier, but also possible of course. The reason is that the navbar should be shown as usual on some occasions when a backdrop is active, e.g. when showing the navigation on mobile. Personally, if I may say that, I'd rather not do that. |
This should now also work with v0.0.6 @editwentyone 🚀 |
This PR adds a cheatsheet component.
It is currently only shown in
devMode
for now, as some items on the list (e.g. Fidelity Bonds), are not yet supported.Differences to the Figma design:
File
as placeholder – found no real alternative on https://bitcoinicons.com/ yet)📸