-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scheduler): invert external/internal toggle #257
Conversation
internal -> external
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good change! Much clearer than before. 👏 👍
One issue though: When the screen initially loads, the internal destination addresses won't be set and the button "Start" button will be disabled. That's because the internal addresses will only be set once the toggle is actively un-toggled. Only after toggling the button back and forth will the internal addresses be set and the button be activated.
With the new logic, we'll need to provide internal destination addresses as default values for the address fields.
Screen.Recording.2022-05-12.at.10.11.08.mov
b6536b2
to
e2f1d59
Compare
Pushed a fix that should work (I hope). TL;DR: Waits with rendering the form unil the wallet is loaded. Once the wallet is loaded, sets the form's initial values to 3 internal addresses. @theborakompanioni Can you have a quick look please? 🙏 Don't want to approve my own code. 😅 |
Ah, damn. Thanks for catching and fixing that! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
This PR inverts the external address toggle and adjusts the behavior of the scheduler to "internal" by default.
Also adjusts and updates copy, fixing #248