fix(fees): allow min tx fee of 1sat/vbyte #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires JM
v0.9.9or greater -> needs #585 to be merged and a recreated dev environment by runningnpm run regtest:rebuild!Before this commit, minimum in Jam was 3 sats/vbyte as prior ot JM
v0.9.9, this resulted in an error, as JM used to little fees and the tx was rejected from the mempool.When this commit is applied, setting the tx fee to 1 sat/vbyte is allowed.
How to test
Set your tx fees to 1 sat/vbyte (with 0% randomization) and try to spend an expired fidelity bond.