Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): display frozen balance on jars #635

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

theborakompanioni
Copy link
Collaborator

Resolves #634.

Displays the frozen or locked balance in the Jars component.

Before

After

@theborakompanioni theborakompanioni self-assigned this Aug 13, 2023
@theborakompanioni theborakompanioni requested review from httpiga and editwentyone and removed request for httpiga August 13, 2023 18:10
@theborakompanioni theborakompanioni force-pushed the feat/display-frozen-balance branch from 4ba75cf to 1129e6b Compare August 13, 2023 18:23
@theborakompanioni theborakompanioni mentioned this pull request Aug 13, 2023
6 tasks
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Aug 14, 2023

This is really just a suggestion. Any suggestion on how to better display frozen funds is highly appreciated.
Maybe one can display a few ice cubes in jars with frozen UTXOs.. 🧊 🧊 🧊 ?

@theborakompanioni theborakompanioni force-pushed the feat/display-frozen-balance branch from 1129e6b to 592bde7 Compare August 14, 2023 08:44
Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK, it does introduce a new text color, but that's visually useful here. There's no UI clutter when there's no frozen funds.

Well done!

@editwentyone
Copy link

for the time beeing its already usefull and really quickly implemented, plus its already motivating the user to click on it to "look inside"

never the less i will think about the other idea and play around with it

@theborakompanioni theborakompanioni added the enhancement New feature or request label Aug 16, 2023
@theborakompanioni theborakompanioni merged commit b029c92 into master Aug 17, 2023
@theborakompanioni theborakompanioni deleted the feat/display-frozen-balance branch August 17, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: show frozen/locked balance for Jars
3 participants