636 check for existing wallet

[zmjohnso]

This PR is a fix for #636. When creating a new wallet, the wallet name will now be validated immediately for duplicates, instead of on form submission when the user clicks "Create".

636.mov

Additionally, this PR refactors the getWalletAll api calls to use react router loaders. This should facilitate async data loading as well as reduce extraneous useEffect and useState calls. Using react router loaders/actions while making more use of errorElement's instead of extra useEffect/useState calls feels like a good pattern that could be explored more in the future...

I did do manual testing, but I am not 100% confident I was able to capture all existing functionality, especially in src/components/Wallets.tsx. This could use some extra eyes.

Many thanks to @theborakompanioni for drawing my attention to using react router loaders to fix this bug 🙌

[theborakompanioni]

Hey @zmjohnso! Thanks so much!

Seems the "import wallet" flow is currently not working (react_router_dom__WEBPACK_IMPORTED_MODULE_6__.useLoaderData() is undefined).

[zmjohnso]

Hey @zmjohnso! Thanks so much!

Seems the "import wallet" flow is currently not working (react_router_dom__WEBPACK_IMPORTED_MODULE_6__.useLoaderData() is undefined).

My bad, missed that file when changing the return type of useLoaderData(). Should be good now!

[theborakompanioni]

So, I have looked over the changes and think it is really nice. If this works well, we should use it more extensively and finally get rid of custom loading indicators per page component.

However, what I noticed is that the requests are often repeatedly invoked. e.g. if you just use the theme toggle (top right corner), you'll see that everytime the button is pressed, multiple "get all wallets" requests are made. I did not investigate too much but maybe you have an idea why that is?

Additionally, if we can rectify this behaviour, "import wallet" should also check for already existing wallet names. 🙌
Hope we can somehow find the root cause of this. 🙌
Do you have any ideas?