Refactor/show utxos #805
Refactor/show utxos #805
Conversation
barrytra
requested review from
theborakompanioni,
0xSaksham,
editwentyone and
amitx13
src/components/Send/ShowUtxos.tsx
Outdated
| } | ||
| }, | ||
| [frozenUtxos, unFrozenUtxos, setUnFrozenUtxos, setFrozenUtxos], | ||
| ) |
There was a problem hiding this comment.
I think shortening this piece of code would give the same results. Not sure though, please go through this.
| @@ -160,7 +160,7 @@ const UtxoRow = memo( | |||
| type="checkbox" | |||
| checked={checked} | |||
| onChange={() => { | |||
| onToggle && onToggle(utxoIndex, isFrozen) | |||
There was a problem hiding this comment.
what will happen to isFrozen that we're not getting from above, how would you handle frozen utxo and non-frozen utxo?
There was a problem hiding this comment.
utxo will contain all the properties of the particularly selected utxo. So to access isFrozen property we can use utxo.isFrozen. Basically we are trying to access whole utxo instead of just one of its property isFrozen.
I thought of doing that. But |
In the show Utxos file, Instead of passing a single parameter
isFrozentotogglefunction, passing wholeutxodata is better. As utxo's other data is need in fidelity bond section.I am not able to review the changes due to some backend issue :(